Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icu_capi features, bump to 1.2.1 #3344

Merged
merged 8 commits into from
Apr 18, 2023
Merged

Fix icu_capi features, bump to 1.2.1 #3344

merged 8 commits into from
Apr 18, 2023

Conversation

Manishearth
Copy link
Member

No description provided.

@Manishearth Manishearth requested a review from a team as a code owner April 18, 2023 01:14
@Manishearth Manishearth requested a review from sffc April 18, 2023 01:14
sffc
sffc previously approved these changes Apr 18, 2023
View reviewed changes
@sffc
Copy link
Member

sffc commented Apr 18, 2023

Need to gn gen

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Cargo.lock is now changed in the branch
  • CHANGELOG.md is now changed in the branch
  • ffi/gn/Cargo.lock is now changed in the branch
  • ffi/gn/icu4x/BUILD.gn is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • CHANGELOG.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc
Copy link
Member

sffc commented Apr 18, 2023 •
edited
Loading

cargo check-all-features really doesn't like this PR

sffc
sffc reviewed Apr 18, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
sffc
sffc reviewed Apr 18, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Manishearth Manishearth requested a review from sffc April 18, 2023 02:54
@codecov-commenter
Copy link

Codecov Report

Merging #3344 (1d02b32) into main (6af64d2) will not change coverage.
The diff coverage is n/a.

❗ Current head 1d02b32 differs from pull request most recent head 2d96378. Consider uploading reports for the commit 2d96378 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3344   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files         689      689           
  Lines       43267    43267           
=======================================
  Hits        32446    32446           
  Misses      10821    10821

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Manishearth Manishearth merged commit 109bdd5 into unicode-org:main Apr 18, 2023
@Manishearth Manishearth deleted the capi_features branch April 18, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Manishearth @sffc @codecov-commenter